Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore V1 --format "table..." support #7932

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Restore V1 --format "table..." support #7932

merged 1 commit into from
Oct 7, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Oct 5, 2020 •
edited
Loading

  • 'containers mount'
  • 'image history'
  • 'images mount'
  • 'images search'
  • Correct spelling errors

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Oct 5, 2020
@jwhonce jwhonce self-assigned this Oct 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@jwhonce jwhonce marked this pull request as draft October 5, 2020 22:50
@jwhonce jwhonce marked this pull request as ready for review October 6, 2020 00:01
@jwhonce jwhonce requested review from ashley-cui and ParkerVR October 6, 2020 00:19
@jwhonce jwhonce changed the title [WIP] Restore V1 --format "table..." support Restore V1 --format "table..." support Oct 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2020
@jwhonce jwhonce force-pushed the jira/run-898 branch 3 times, most recently from adc82b6 to b2b1eb8 Compare October 6, 2020 21:25
@jwhonce
Port commands to V2 --format 'table...'
b490905 
 * 'containers mount'
 * 'image history'
 * 'images mount'
 * 'images search'
 * Correct spelling errors

Signed-off-by: Jhon Honce <[email protected]>
@ParkerVR
Copy link
Collaborator

ParkerVR commented Oct 7, 2020

/lgtm
I should be available to work with you on this soon

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@mheon
Copy link
Member

mheon commented Oct 7, 2020

/hold
CI isn't green yet, applying hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@jwhonce
Copy link
Member Author

jwhonce commented Oct 7, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit 59b5f0a into containers:master Oct 7, 2020
@ParkerVR ParkerVR mentioned this pull request Oct 8, 2020
Merged
@jwhonce jwhonce deleted the jira/run-898 branch June 30, 2021 16:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui Awaiting requested review from ashley-cui

@ParkerVR ParkerVR Awaiting requested review from ParkerVR

Assignees

@jwhonce jwhonce

@ParkerVR ParkerVR

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwhonce @openshift-ci-robot @ParkerVR @mheon @openshift-merge-robot