DO NOT MERGE! Revert "Properly handle podman run --pull command"

[edsantiago]

DO NOT MERGE! This is a dummy PR for the sole purpose of
running CI tests.

I really need to understand why my system tests did not catch
the "podman run --pull" problem addressed by #7770. So this
commit leaves the new tests in place, but reverts the code
changes. That should make these tests fail, and I will be
better able to understand why my tests failed to catch it.

I thought I had ginkgo working on my laptop, but running:

ginkgo -trace -debug -r -focus 'with --pull' test/e2e

...only yields success. I suspect there's something deeper
going on here but can only find out by running the full CI
test suite. Sorry to be wasting cycles.

This reverts commit 1b5853e.

Signed-off-by: Ed Santiago [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago I think the common case was covered before my PR which is why your tests were passing. The !alltags path was not being handled as well.

if strings.HasSuffix(dName, "/"+searchName) && dSuspiciousTagValueForSearch == searchSuspiciousTagValueForSearch {
--------------------------------------^

This change is what was causing all of the failures I was seeing. Basically I had two images within my storage myfedora and fedora, and because of this everytime I tried to run a fedora container, the code was reaching out to the registry.

[edsantiago]

@rhatdan ack, I have a test for that right now, and it is (as expected) failing in pre-7770, passing in post. I will submit a PR within the hour. Thank you for the clarification!

[edsantiago]

Submitted: #7828 to add new tests.