Usability: prevent "-l" with arguments #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
edsantiago
force-pushed
the
minus_l_with_other_args
branch
from
5250745 to
3f387d8
Compare
Luap99
reviewed
Sep 14, 2020
cmd/podman/containers/top.go
Outdated
Comment on lines
94
to
96
| if len(args) > 0 && topOptions.Latest { | ||
| return errors.Errorf("--latest and containers cannot be used together") | ||
| } |
There was a problem hiding this comment.
podman top shouldn't check this. This is valid:
$ bin/podman top -l pid user
PID USER
1 root
There was a problem hiding this comment.
Good catch, thank you. Fixed.
cmd/podman/pods/top.go
Outdated
Comment on lines
71
to
73
| if len(args) > 0 && topOptions.Latest { | ||
| return errors.Errorf("--latest and pods cannot be used together") | ||
| } |
Add new system check confirming that "podman foo -l arg" throws an error; and fix lots of instances where code was not doing this check. I'll probably need to add something similar for --all but that can wait. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
minus_l_with_other_args
branch
from
3f387d8 to
2583948
Compare
|
LGTM |
|
LGTM |
|
/lgtm |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 15, 2020
PR containers#7633 disallowed "-l" (--latest) with container args. PR containers#7630 made changes to the "podman wait" command. The error message it issues is inconsistent (and incompatible) with the one required by the new BATS --help test. Fix that. This is entirely my fault. I was aware of containers#7630, and I was careful to check the output message format, but I was not careful enough (I trusted my eyes, not my code). Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new system check confirming that "podman foo -l arg"
throws an error; and fix lots of instances where code
was not doing this check.
I'll probably need to add something similar for --all but
that can wait.
Signed-off-by: Ed Santiago [email protected]