podman wait accept args > 1

[Luap99]

Fixes #7627

[rhatdan]

LGTM

[edsantiago]

Before we go through with this: do we really, really want this? I see this as a huge can of worms: how exactly is multi-wait defined? Is it AND or OR? Right now it looks like it's sequential AND:

$ ./bin/podman run -d --name foo1 ... sleep 90
$ !!:gs/90/5/
$ ./bin/podman wait foo1 foo2      (hangs for ~90 seconds with no output)
0
0

If this is truly the desired behavior -- and it might not be, because I for one was expecting "wait for any one of these" -- I believe it should be clearly documented in the man page.

I would encourage is all to step back and maybe consider saying "podman wait takes exactly one argument".

[Luap99]

@edsantiago According to the man page this is how it should work. https://github.com/containers/podman/blob/master/docs/source/markdown/podman-wait.1.md#description

[edsantiago]

@Luap99 thanks but that's still an unhelpful description: it does not specify how the exit codes are emitted (by command-line order? by order of which exited first?) Whether or not this approach is desired, that whole description needs a lot of work.

[Luap99]

@edsantiago A quick test shows it will print in the same order as the given containers and will only print the exit codes after all containers exited.

$ bin/podman run --name 1 -d alpine sh -c "sleep 20; exit 1"
e1e6c2be23ccab5f85aa575d35c9f3b6726b1c97f1d277f5a28ac340d2a9fc0b
$ bin/podman run --name 2 -d alpine sh -c "sleep 10; exit 2"
354adb8744b4433466fcf2e16e68b093cfc8f42a8eb3effd8f95de593e0e3791
$ bin/podman wait 1 2
1
2
$ bin/podman rm 1 2
354adb8744b4433466fcf2e16e68b093cfc8f42a8eb3effd8f95de593e0e3791
e1e6c2be23ccab5f85aa575d35c9f3b6726b1c97f1d277f5a28ac340d2a9fc0b
$ bin/podman run --name 1 -d alpine sh -c "sleep 20; exit 1"
069d21ada22bdf464d29fff5faa238b343485d9db93e25b43ae302064545bc6a
$ bin/podman run --name 2 -d alpine sh -c "sleep 10; exit 2"
8d0b2f7482017a8e98e5a3d247e11c9ddf12bed6e21719164af194e553cf2d19
$ bin/podman wait 2 1 
2
1

[edsantiago]

A quick test shows it will print in the same order as the given containers and will only print the exit codes after all containers exited.

Understood; that was my experience as well. My point is, this should be clearly and unambiguously documented in the man page.

[Luap99]

@edsantiago @rhatdan PTAL
I have updated the man page.

[edsantiago]

Orthographic nit. Aside from that, if this truly is the desired behavior for wait, it lgtm.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

/lgtm