Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VM images for new crun; adapt Cap tests to work with new kernel #7538

Merged

Conversation

edsantiago
Copy link
Member

(This is an adoption of #7533 because Brent is on PTO).

Pick up new crun and crio-runc.

Also: renames from useful fedora-32 and -31 to less-useful
names; presumably this is needed by something-something in
the new VM setup.

Also: tweak two e2e tests to more properly handle a kernel
(5.8.4) with a greater set of capabilities than what we
or crun can yet handle.

Signed-off-by: Ed Santiago [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2020
@edsantiago edsantiago force-pushed the cap_test_robust branch 6 times, most recently from 149f78e to a0f5f53 Compare September 3, 2020 20:05
(This is an adoption of containers#7533 because Brent is on PTO).

Pick up new crun and crio-runc.

Also: renames from useful fedora-32 and -31 to less-useful
names; presumably this is needed by something-something in
the new VM setup.

Also: tweak two e2e tests to more properly handle a kernel
(5.8.4) with a greater set of capabilities than what we
or crun can yet handle.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

I'm ashamed at the number of pushes I had to do. Should I ever need to deal with ginkgo again (and, sigh, it seems likely), I will take time to figure out a way to run it locally.

Test seems to work. See, e.g., test fedora RCLI:false which shows different CapEff for host & container. What that doesn't show is if my logic is correct, e.g. the test could just as easily pass if ParseUint() is returning 1 for each value. So please, dear reviewer, apply a careful eye to that code.

@edsantiago edsantiago changed the title WIP: update VM images Update VM images Sep 8, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@edsantiago edsantiago changed the title Update VM images Update VM images for new crun; adapt Cap tests to work with new kernel Sep 8, 2020
@rhatdan
Copy link
Member

rhatdan commented Sep 8, 2020

LGTM
@baude @cevich @mheon PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 8, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@mheon
Copy link
Member

mheon commented Sep 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 11679c2 into containers:master Sep 8, 2020
@edsantiago edsantiago deleted the cap_test_robust branch September 15, 2020 19:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants