Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]update vm images #7533

Closed
wants to merge 1 commit into from
Closed

[WIP]update vm images #7533

wants to merge 1 commit into from

Conversation

baude
Copy link
Member

@baude baude commented Sep 2, 2020

pick up new crun and crio-runc

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@baude baude force-pushed the imageupdate-c5809900649447424 branch from a270774 to 34bae31 Compare September 2, 2020 15:34
@baude
update vm images
68d89f9 
pick up new crun and crio-runc

fix issue where bash was being eval'd incorrectly.

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the imageupdate-c5809900649447424 branch from 34bae31 to 68d89f9 Compare September 2, 2020 17:17
@edsantiago edsantiago mentioned this pull request Sep 3, 2020
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Sep 3, 2020
@edsantiago
WIP: update VM images
36caf4e 
(This is an adoption of containers#7533 because Brent is on PTO).

Pick up new crun and crio-runc.

Also: renames from useful fedora-32 and -31 to less-useful
names; presumably this is needed by something-something in
the new VM setup.

Also: tweak two e2e tests to more properly handle a kernel
(5.8.4) with a greater set of capabilities than what we
or crun can yet handle.

Signed-off-by: Ed Santiago <[email protected]>
vrothberg
vrothberg reviewed Sep 7, 2020
View reviewed changes
.cirrus.yml
PRIOR_FEDORA_NAME: "fedora-31"
UBUNTU_NAME: "ubuntu-20"
PRIOR_UBUNTU_NAME: "ubuntu-19"
FEDORA_NAME: "fedora"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have the versions embedded in the names. Seeing them in the CI interface can help reminding us to update (and not forget about old versions).

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2020
@openshift-ci-robot
Copy link
Collaborator

@baude: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

It would seem that this PR is old and needs to be closed?

@rhatdan rhatdan closed this Nov 14, 2020
@baude baude deleted the imageupdate-c5809900649447424 branch May 18, 2022 15:19
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baude @openshift-ci-robot @rhatdan @vrothberg