Accept multiple Content-Types for building an image #7208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orenbm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
orenbm
force-pushed
the
accept-multiple-content-types
branch
2 times, most recently
from
bedc733 to
025d131
Compare
Currently we accept only the 'application/x-tar' header when sending the tar file for building an image. However, this header has the aliases 'application/tar' and 'application/x-gtar' so we should accept those as well. Furthermore, docker-compose uses 'application/tar' so accepting this content-type will take us one step further in supporting docker-compose with the Podman API. Signed-off-by: orenbm <[email protected]>
orenbm
force-pushed
the
accept-multiple-content-types
branch
from
025d131 to
9024370
Compare
|
thanks @mheon , didn't see that. I'll leave a comment there and close this one. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: orenbm [email protected]
Fixes: #7185
Currently we accept only the 'application/x-tar' header when sending
the tar file for building an image. However, this header has the aliases
'application/tar' and 'application/x-gtar'
so we should accept those as well.
Furthermore, docker-compose uses 'application/tar' so accepting this content-type
will take us one step further in supporting docker-compose with the Podman API.