docker-compose uses application/tar #7205
Conversation
even though the official documentation suggests that application/x-tar should be used for tar files, it seems docker-compose uses application/tar. we now accept them and issue a warning. Fixes: containers#7185 Signed-off-by: Brent Baude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
| case "application/tar": | ||
| logrus.Warnf("tar file content type is %s, should use \"application/x-tar\" content type", contentType) |
There was a problem hiding this comment.
application/x-gtar is also an alias of application/x-tar. Do we want to add the same behaviour for that header as well? let it work and write a warning.
There was a problem hiding this comment.
i wouldnt reject a pr for it. but otherwise, how about we wait until we are asked for it ?
There was a problem hiding this comment.
I see no harm in implementing this in another PR but i can also live with not implementing it for now. application/tar was important for supporting docker-compose, I am not aware of a tool that uses application/x-gtar.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
even though the official documentation suggests that application/x-tar should be used for tar files, it seems docker-compose uses application/tar. we now accept them and issue a warning.
Fixes: #7185
Signed-off-by: Brent Baude [email protected]