Speedup static build by utilizing CI cache on /nix folder
#7076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
force-pushed
the
master-linux-amd64
branch
27 times, most recently
from
7dc4bbe to
d80e994
Compare
This was referenced Jul 26, 2020
|
LGTM |
hswong3i
force-pushed
the
master-linux-amd64
branch
from
d80e994 to
76eefdd
Compare
2 tasks
|
@rhafer @saschagrunert I am checking why the reuse of cache result as "Cache miss", but reupload of cache result as "Already uploaded", see cirruslabs/cirrus-ci-docs#681 |
hswong3i
force-pushed
the
master-linux-amd64
branch
from
76eefdd to
3a00f56
Compare
Hm yeah it seems not working at all 🤔 |
hswong3i
force-pushed
the
master-linux-amd64
branch
6 times, most recently
from
48253fa to
7ddd608
Compare
|
@rhatdan @saschagrunert as cirruslabs/cirrus-ci-docs#681 get fixed now static binary build phase reduce from ~40mins to ~4mins (https://cirrus-ci.com/task/5522320095707136), by caching and reuse previous dependency build result ;-) |
bors bot
added a commit
to containers/buildah
that referenced
this pull request
Jul 30, 2020
2428: Build static binary with `buildGoModule` r=rhatdan a=hswong3i <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind cleanup #### What this PR does / why we need it: [nix] Build Static Binary with `buildGoModule` Switch from nix `channel:nixpkgs-unstable` to `channel:nixos-20.03` for better stability. Also see: - containers/crun#428 - containers/conmon#189 - containers/skopeo#973 - #2428 - containers/podman#7076 - cri-o/cri-o#4012 #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Build static binary with `buildGoModule` ``` Co-authored-by: Wong Hoi Sing Edison <[email protected]>
bors bot
added a commit
to containers/buildah
that referenced
this pull request
Jul 30, 2020
2428: Build static binary with `buildGoModule` r=rhatdan a=hswong3i <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind cleanup #### What this PR does / why we need it: [nix] Build Static Binary with `buildGoModule` Switch from nix `channel:nixpkgs-unstable` to `channel:nixos-20.03` for better stability. Also see: - containers/crun#428 - containers/conmon#189 - containers/skopeo#973 - #2428 - containers/podman#7076 - cri-o/cri-o#4012 #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Build static binary with `buildGoModule` ``` Co-authored-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
master-linux-amd64
branch
from
7ddd608 to
ada0605
Compare
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
master-linux-amd64
branch
from
ada0605 to
daaccf8
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hswong3i, mheon, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see:
--disable-systemdfor CentOS/RHEL 7 crun#428/nixfolder conmon#189buildGoModuleskopeo#973buildGoModulebuildah#2428/nixfolder #7076/nixfolder cri-o/cri-o#4012Signed-off-by: Wong Hoi Sing Edison [email protected]