Speedup static build by utilizing CI cache on /nix folder
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
force-pushed
the
master-linux-amd64
branch
6 times, most recently
from
c29a1b2 to
2126a7d
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
14 times, most recently
from
3a08038 to
e7b462e
Compare
This was referenced Jul 26, 2020
hswong3i
force-pushed
the
master-linux-amd64
branch
from
e7b462e to
1972b26
Compare
2 tasks
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
3aa4f15 to
a853710
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
3 times, most recently
from
9d1fc5e to
3296695
Compare
|
Since cirruslabs/cirrus-ci-docs#681 already get fixed, the static binary build phase should now speeding up, with a shared logic with containers/buildah#2428 and containers/podman#7076. BTW, seems most CI test cases for conmon are now failing at the beginning, CI related to this PR couldn't be triggered... |
bors bot
added a commit
to containers/buildah
that referenced
this pull request
Jul 30, 2020
2428: Build static binary with `buildGoModule` r=rhatdan a=hswong3i <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind cleanup #### What this PR does / why we need it: [nix] Build Static Binary with `buildGoModule` Switch from nix `channel:nixpkgs-unstable` to `channel:nixos-20.03` for better stability. Also see: - containers/crun#428 - containers/conmon#189 - containers/skopeo#973 - #2428 - containers/podman#7076 - cri-o/cri-o#4012 #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Build static binary with `buildGoModule` ``` Co-authored-by: Wong Hoi Sing Edison <[email protected]>
bors bot
added a commit
to containers/buildah
that referenced
this pull request
Jul 30, 2020
2428: Build static binary with `buildGoModule` r=rhatdan a=hswong3i <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind cleanup #### What this PR does / why we need it: [nix] Build Static Binary with `buildGoModule` Switch from nix `channel:nixpkgs-unstable` to `channel:nixos-20.03` for better stability. Also see: - containers/crun#428 - containers/conmon#189 - containers/skopeo#973 - #2428 - containers/podman#7076 - cri-o/cri-o#4012 #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Build static binary with `buildGoModule` ``` Co-authored-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
7b59ce4 to
9fe2abb
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
e8d5abb to
903e127
Compare
This was referenced Aug 11, 2020
hswong3i
force-pushed
the
master-linux-amd64
branch
from
903e127 to
6d8ebcd
Compare
bors bot
added a commit
to containers/buildah
that referenced
this pull request
Aug 11, 2020
2533: Update nix pin with `make nixpkgs` r=rhatdan a=hswong3i <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind cleanup > /kind feature #### What this PR does / why we need it: Update nix pin with `make nixpkgs` Also sync nix `packageOverrides` across skopeo/buildah/podman/cri-o for utilizing local build cache, see - containers/crun#450 - containers/conmon#189 - containers/skopeo#973 - #2533 - containers/podman#7286 - cri-o/cri-o#4065 #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Update nix pin with `make `nixpkgs` ``` Co-authored-by: Wong Hoi Sing Edison <[email protected]>
|
@saschagrunert could we give a merge for this? |
|
/retest |
|
I think we should somehow revive the CI first :D |
|
😅 I will try to work with @cevich this week |
|
ci is (mostly) fixed, please rebase! |
hswong3i
force-pushed
the
master-linux-amd64
branch
from
6d8ebcd to
360b541
Compare
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
master-linux-amd64
branch
from
360b541 to
e3a7258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see:
--disable-systemdfor CentOS/RHEL 7 crun#428/nixfolder #189buildGoModuleskopeo#973buildGoModulebuildah#2428/nixfolder podman#7076/nixfolder cri-o/cri-o#4012Signed-off-by: Wong Hoi Sing Edison [email protected]