Vendor in new version of Buildah #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2020
vrothberg
reviewed
Jul 8, 2020
|
The gating test looks legitimate, not CI being down |
|
LGTM Compiles for me, as does pids-limit rebased on it. Not sure why CI is failing |
|
CI is a basket case, because of the libpod->podman Rename. Hopefully this will get fixed soon. |
rhatdan
force-pushed
the
VENDOR
branch
3 times, most recently
from
19b5dea to
9b4c50f
Compare
|
@vrothberg @mheon @baude @ashley-cui @QiWang19 @goochjj PTAL |
|
LGTM |
1 similar comment
|
LGTM |
rhatdan
force-pushed
the
VENDOR
branch
2 times, most recently
from
642def1 to
f98bc17
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rhatdan
force-pushed
the
VENDOR
branch
3 times, most recently
from
d2b4e87 to
4cba2a6
Compare
We are using these dependencies just to get the device from path. These dependencies no longer build on Windows, so simply cloning the deviceFromPath function, we can eliminate the need for this vendoring. Signed-off-by: Daniel J Walsh <[email protected]>
This also pulls in latest runc and containers/common Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also pulls in latest runc and containers/common
Signed-off-by: Daniel J Walsh [email protected]