oci conmon: tell conmon to log container name #6291
Conversation
specifying `-n=ctr-name` tells conmon to log CONTAINER_NAME=name if the log driver is journald add this, and a test! also, refactor the args slice creation to not append() unnecessarily. Signed-off-by: Peter Hunt <[email protected]>
| @@ -173,6 +173,24 @@ var _ = Describe("Podman logs", func() { | |||
| Expect(string(out)).To(ContainSubstring("alpine")) | |||
| }) | |||
|
|
|||
| It("podman journald logs for container name", func() { | |||
| Skip("need to verify images have correct packages for journald") | |||
There was a problem hiding this comment.
all of the logs tests are always skipped
There was a problem hiding this comment.
they're actually skipped in two different spots 😄
|
LGTM |
|
all logs tests are skipped here I have a feeling fully enabling the test will be a bit more challenging than dropping these. do you two want me to address those here @rhatdan @vrothberg ? |
Only for remote though.
If you have some cycles for that, it would be great. Adding disabled tests is not ideal. |
|
I have about enough cycles to attempt to enable them, but I can't promise carrying through fixing the tests if they fail from v2/not having journalctl on the images |
|
(also without containers/conmon#154 the test will fail) |
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
journald-container-name
branch
from
1d03585 to
d2d338b
Compare
|
update: ci images do not have journald. I would like to enable the tests as a follow up |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
specifying
-n=ctr-nametells conmon to log CONTAINER_NAME=name if the log driver is journaldadd this, and a test!
also, refactor the args slice creation to not append() unnecessarily.
technically, this needs containers/conmon#154, though the test is skipped anyway
Signed-off-by: Peter Hunt [email protected]