Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journald: fix logging container name #154

Merged

Conversation

haircommander
Copy link
Collaborator

@haircommander haircommander commented May 20, 2020

When conmon writes a field with the incorrect length, it is not displayed correctly by journalctl. that can make it seem like the CONTAINER_NAME field is not being added, when in reality it's not formatted correctly.
Signed-off-by: Peter Hunt [email protected]

@mheon
Copy link
Member

mheon commented May 20, 2020

LGTM

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented Jun 8, 2020

@haircommander What's the status here?

@haircommander haircommander merged commit f951578 into containers:master Jun 8, 2020
@haircommander
Copy link
Collaborator Author

should be innocuous, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants