Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podmanimage files to adjust perms on containers.conf for rootless #6010

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Update podmanimage files to adjust perms on containers.conf for rootless #6010

merged 1 commit into from
Apr 29, 2020

Conversation

TomSweeneyRedHat
Copy link
Member

Adding the changes to the Podman image Docker/Containerfiles similar
to @rhatdan 's changes in containers/buildah#2332

In short it changes the perms on containers.conf so it can be used by a
rootless user.

Signed-off-by: TomSweeneyRedHat [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
Adding the changes to the Podman image Docker/Containerfiles similar
to @rhatdan 's changes in containers/buildah#2332

In short it changes the perms on containers.conf so it can be used by a
rootless user.

Signed-off-by: TomSweeneyRedHat <[email protected]>
@TomSweeneyRedHat
Copy link
Member Author

OK, I'm stumped. is this a known issue with the builds? It's always the small innocuous changes that bite me. I didn't touch anything in testing or go code, just changes to Dockerfiles that are used by quay.io to make the container images.

# github.com/rootless-containers/rootlesskit/pkg/port/builtin/parent
vendor/github.com/rootless-containers/rootlesskit/pkg/port/builtin/parent/parent.go:94:9: undefined: "github.com/pkg/errors".Is
make[1]: *** [Makefile:185: bin/podman] Error 2
make[1]: Leaving directory '/root/rpmbuild/BUILD/libpod-9229312f'
error: Bad exit status from /var/tmp/rpm-tmp.2CdjQQ (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.2CdjQQ (%build)
make: *** [Makefile:667: package] Error 1

@rhatdan
Copy link
Member

rhatdan commented Apr 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit d1196d0 into containers:master Apr 29, 2020
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/ctrimagefixes branch August 14, 2020 18:31
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants