Fix permissions on containers.conf #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the https://github.com/containers/buildah/blob/master/contrib/buildahimage/stablebyhand/Containerfile.buildahstable file too please? It's too bad ADD/COPY doesn't have a |
When running in a rootless buildah, the build user is not allowed to read /etc/containers/containers.conf which is causing these containers to fail. This patch makes containers.conf world readable. Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
force-pushed
the
containers.conf
branch
from
9f403d0 to
da071e1
Compare
|
@TomSweeneyRedHat Updated. |
|
Thx @rhatdan |
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors retry |
|
Build succeeded:
|
|
@cevich it went through, thanks for the help! |
snj33v
pushed a commit
to snj33v/libpod
that referenced
this pull request
May 31, 2020
Adding the changes to the Podman image Docker/Containerfiles similar to @rhatdan 's changes in containers/buildah#2332 In short it changes the perms on containers.conf so it can be used by a rootless user. Signed-off-by: TomSweeneyRedHat <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a rootless buildah, the build user
is not allowed to read /etc/containers/containers.conf
which is causing these containers to fail.
This patch makes containers.conf world readable.
Signed-off-by: Daniel J Walsh [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?