Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move podman-service to podman-system-service #5111

Merged

Conversation

mheon
Copy link
Member

@mheon mheon commented Feb 6, 2020

Alleviates a conflict with the unrelated docker service command

Fixes #5108

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@mheon mheon force-pushed the service_to_system_service branch from 22365ae to 180acbd Compare February 6, 2020 18:25
@mheon mheon force-pushed the service_to_system_service branch from 180acbd to 41b735a Compare February 6, 2020 18:42
@mheon
Copy link
Member Author

mheon commented Feb 6, 2020

@rhatdan @baude @vrothberg @jwhonce PTAL

@baude
Copy link
Member

baude commented Feb 6, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@baude
Copy link
Member

baude commented Feb 6, 2020

i want to know more about this before it gets merged

@baude
Copy link
Member

baude commented Feb 6, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@baude
Copy link
Member

baude commented Feb 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 35eb238 into containers:master Feb 6, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: rename podman service to avoid conflict with docker service
4 participants