Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: rename podman service to avoid conflict with docker service #5108

Closed
AkihiroSuda opened this issue Feb 6, 2020 · 16 comments · Fixed by #5111
Closed

suggestion: rename podman service to avoid conflict with docker service #5108

AkihiroSuda opened this issue Feb 6, 2020 · 16 comments · Fixed by #5111
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@AkihiroSuda
Copy link
Collaborator

podman service looks as if it was Podman's implementation of docker service.

I suggest renaming podman service to podman daemon, because it seems actually reimplementation of docker daemon that had existed in Docker 1.10 and prior versions.

@mheon
Copy link
Member

mheon commented Feb 6, 2020

We're trying to avoid running this as a daemon (using systemd socket-activation, and having a timeout on the command so it's not always on), so podman daemon is probably a bad idea, but I'm not opposed to renaming to ensure we don't conflict.

@mheon
Copy link
Member

mheon commented Feb 6, 2020

If so, we should do this quick, before we cut a 1.8.0 final and formalize the name in an official release

@mheon
Copy link
Member

mheon commented Feb 6, 2020

@baude @rhatdan @vrothberg PTAL

@AkihiroSuda
Copy link
Collaborator Author

Or maybe podman system service

@vrothberg
Copy link
Member

podman listen?

Thanks for pointing that out, @AkihiroSuda !

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

Why would podman service conflict with docker.service?

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

Podman is not listening by default at docker.sock, If you install podman-docker, it will create a linkfile between /run/docker.sock and /run/podman.sock. But podman-docker conflicts with docker-* packages.

@vrothberg
Copy link
Member

There's a docker service command -> https://docs.docker.com/engine/reference/commandline/service/

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

So this is their replacement for dockerd? If it is, then podman service makes sense. Except for not listening on docker.sock?

@mheon
Copy link
Member

mheon commented Feb 6, 2020

No, it's a swarm command, AFAIK - it launches a service via swarm

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

Well we have said we will not support Docker swarm, does it matter we have the same name?

@mheon
Copy link
Member

mheon commented Feb 6, 2020

Potential confusion? I'd prefer not to knowingly conflict with Docker commands if we can afford not to

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

Fine, except that if we come up with a strange name for this service.
podman restapi
podman server

@mheon
Copy link
Member

mheon commented Feb 6, 2020

podman server sounds good to me

@mheon
Copy link
Member

mheon commented Feb 6, 2020

podman system service also works for me

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2020

Yes I like keeping it under system.

mheon added a commit to mheon/libpod that referenced this issue Feb 6, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants