Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troubleshooting: warn about secure boot #4614

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

bfallik
Copy link
Contributor

@bfallik bfallik commented Dec 2, 2019

Add an additional troubleshooting item to warn users that Secure Boot can prevent Podman from running containers. The error messages and initial debugging steps don't make it clear that this stems from a BIOS setting. Hopefully adding this item to the troubleshooting doc will avoid future headaches.

@openshift-ci-robot
Copy link
Collaborator

Hi @bfallik. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels Dec 2, 2019
@bfallik
Copy link
Contributor Author

bfallik commented Dec 2, 2019

/assign @mrunalp

@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2019

@bfallik You need to sign your PR
git commit -a --amend -s
git push --force

@bfallik
Copy link
Contributor Author

bfallik commented Dec 2, 2019

@rhatdan ah, thanks. The lack of signature is probably because I created the PR directly from the Github UI.

@bfallik
Copy link
Contributor Author

bfallik commented Dec 2, 2019

@rhatdan updated, i think

@TomSweeneyRedHat
Copy link
Member

Changes LGTM if we can figure out the gating issue.

@@ -429,3 +428,17 @@ You'll need to either:
or as root if your user has not enough privileges.

* sudo loginctl enable-linger $UID

### 18) `podman run` fails with "bpf create: permission denied error"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space at the end of this line that is causing the tests to fail. Remove the space and repush and we should be able to merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @rhatdan

Add an additional troubleshooting item to warn users that Secure Boot
can prevent Podman from running containers. The error messages and
initial debugging steps don't make it clear that this all stems from a
BIOS setting. Hopefully adding this item to the troubleshooting doc
will avoid future headaches.

Signed-off-by: Brian Fallik <[email protected]>
@bfallik
Copy link
Contributor Author

bfallik commented Dec 3, 2019

I pushed a new commit without the whitespace.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfallik, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@TomSweeneyRedHat
Copy link
Member

LGTM thanks @bfallik !

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit 748de3c into containers:master Dec 3, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants