-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add workaround for --device with rootless containers #4487
docs: add workaround for --device with rootless containers #4487
Conversation
Hi @stefanb2. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
☔ The latest upstream changes (presumably #4614) made this pull request unmergeable. Please resolve the merge conflicts. |
@stefanb2 Could you please rebase. |
Fixes containers#4477 Signed-off-by: Stefan Becker <[email protected]>
6623886
to
aec62d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm thinking about security related implications of such a runtime feature but could not find anything bad right now. 🤷♂️
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, saschagrunert, stefanb2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
Fixes #4477
Signed-off-by: Stefan Becker [email protected]