Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing for UID, GID in volume "o" option #4298

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Add parsing for UID, GID in volume "o" option #4298

merged 1 commit into from
Oct 23, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented Oct 18, 2019

Everything else is a flag to mount, but "uid" and "gid" are not. We need to parse them out of "o" and handle them separately.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Oct 18, 2019
@mheon
Copy link
Member Author

mheon commented Oct 18, 2019

Tests need to wait for #4284

@baude
Copy link
Member

baude commented Oct 22, 2019

lgtm

@mheon
Add parsing for UID, GID in volume "o" option
f60a814 
Everything else is a flag to mount, but "uid" and "gid" are not.
We need to parse them out of "o" and handle them separately.

Signed-off-by: Matthew Heon <[email protected]>
@mheon
Copy link
Member Author

mheon commented Oct 22, 2019

Test added

@TomSweeneyRedHat
Copy link
Member

Looks like a golangci-lint install issue in one of the test suites?

golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
[+0026s] golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
[+0029s] make: *** [Makefile:487: .install.golangci-lint] Error 6
[+0029s] .
[+0029s] setup_environment.sh exit status: 2

@TomSweeneyRedHat
Copy link
Member

LGTM once tests are happy.

@rhatdan
Copy link
Member

rhatdan commented Oct 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4b8832a into containers:master Oct 23, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request Oct 23, 2019
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mheon @openshift-ci-robot @baude @TomSweeneyRedHat @rhatdan @openshift-merge-robot