Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show volume options in 'volume inspect' #4284

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented Oct 17, 2019

We initialized the map to show them, but didn't actually copy them in, so they weren't being displayed.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@rhatdan
Copy link
Member

rhatdan commented Oct 17, 2019

@rhatdan
Copy link
Member

rhatdan commented Oct 17, 2019

@mheon Should probably add a tests to make sure we don't regress in the future.

@mheon
Copy link
Member Author

mheon commented Oct 18, 2019

Added a test

We initialized the map to show them, but didn't actually copy
them in, so they weren't being displayed.

Signed-off-by: Matthew Heon <[email protected]>
@mheon
Copy link
Member Author

mheon commented Oct 18, 2019


[+1174s] Running: (env: [PODMAN_VARLINK_ADDRESS=unix:/run/podman/io.podman-58a3d2dabb74c90295a4e9266c269f590d2fdf7d760a0416b9a6353609178a13]) /var/tmp/go/src/github.com/containers/libpod/bin/podman-remote volume inspect testvol
[+1174s] [
[+1174s]      {
[+1174s]           "Runtime": {
[+1174s]                "Conn": {
[+1174s]                     "Closer": null,
[+1174s]                     "Reader": {},
[+1174s]                     "Writer": {}
[+1174s]                },
[+1174s]                "Remote": true
[+1174s]           }
[+1174s]      }
[+1174s] ]
[+1174s] output: [ { "Runtime": { "Conn": { "Closer": null, "Reader": {}, "Writer": {} }, "Remote": true } } ]

Well that doesn't look right. I think volume inspect is rather broken for remote.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but the remote tests aren't happy

@mheon
Copy link
Member Author

mheon commented Oct 21, 2019

I have rewritten the remote endpoint for volume inspect in a way that will hopefully resolve this

We need to use the new Inspect() endpoint instead of trying to
JSON the actual volume structs. Currently, the output seems
completely nonsensical; it seems like we're JSONing the struct
for the Varlink connection itself? This should restore sanity and
match the format of remote and local inspect on volumes.

Signed-off-by: Matthew Heon <[email protected]>
@mheon
Copy link
Member Author

mheon commented Oct 21, 2019

Tests passing now
@rhatdan @baude @vrothberg @giuseppe @TomSweeneyRedHat PTAL

@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit efc54c3 into containers:master Oct 21, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants