golangci-lint round #3 #3562
Merged
golangci-lint round #3 #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
rhatdan
reviewed
Jul 11, 2019
openshift-ci-robot
added
size/XXL
jwhonce
requested changes
Jul 12, 2019
| @@ -804,7 +804,7 @@ func makeHealthCheckFromCli(c *GenericCLIResults) (*manifest.Schema2HealthConfig | |||
| if err != nil { | |||
| return nil, errors.Wrapf(err, "invalid healthcheck-timeout %s", inTimeout) | |||
| } | |||
| if timeoutDuration < time.Duration(time.Second*1) { | |||
| if timeoutDuration < time.Duration(1) { | |||
There was a problem hiding this comment.
Does the linter accept (time.Duration(1) * time.Second)? I hate to lose the units here.
mheon
reviewed
Jul 12, 2019
|
☔ The latest upstream changes (presumably #3509) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
size/L
and removed
size/XXL
baude
force-pushed
the
golangcilint3
branch
2 times, most recently
from
0b04a8e to
aa0cbef
Compare
|
☔ The latest upstream changes (presumably #3590) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
this is the third round of preparing to use the golangci-lint on our code base. Signed-off-by: baude <[email protected]>
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
This was referenced Jul 22, 2019
Merged
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the third round of preparing to use the golangci-lint on our
code base.
Signed-off-by: baude [email protected]