Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking: use firewall plugin #2940

Merged
merged 1 commit into from
Aug 21, 2019
Merged

networking: use firewall plugin #2940

merged 1 commit into from
Aug 21, 2019

Conversation

giuseppe
Copy link
Member

drop the pkg/firewall module and start using the firewall CNI plugin.
It requires an updated package for CNI plugins.

Signed-off-by: Giuseppe Scrivano [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL labels Apr 15, 2019
@giuseppe giuseppe mentioned this pull request Apr 17, 2019
Closed
@mheon
Copy link
Member

mheon commented Jun 3, 2019

@giuseppe We might need this to resolve bugs with CNI 0.8.0 - mind rebasing? We can start looking into CI from there.

@giuseppe
Copy link
Member Author

giuseppe commented Jun 3, 2019

@giuseppe We might need this to resolve bugs with CNI 0.8.0 - mind rebasing? We can start looking into CI from there.

rebased, but I think we need a version of the CNI plugins first

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL labels Jun 3, 2019
@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2019

@giuseppe Any update on this PR?

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3180) made this pull request unmergeable. Please resolve the merge conflicts.

@mheon
Copy link
Member

mheon commented Jun 8, 2019 via email

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3378) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2019
@mheon
Copy link
Member

mheon commented Jul 10, 2019

We have 0.8.1 in the repos now, so we should be good to try this now.

@mheon
Copy link
Member

mheon commented Jul 10, 2019

Correction: Needs #3534 first

@mheon
Copy link
Member

mheon commented Aug 14, 2019

Everything should go green if you rebase @giuseppe

@giuseppe
Copy link
Member Author

Everything should go green if you rebase @giuseppe

rebased

@mheon
Copy link
Member

mheon commented Aug 15, 2019

/retest

I think we just caught a bunch of flakes here

@mheon
Copy link
Member

mheon commented Aug 15, 2019

F29 did go green. I think this is going to be ready.

@edsantiago
Copy link
Member

/retest

@edsantiago
Copy link
Member

/retest

error is:

http://mirror.cogentco.com/pub/linux/epel/7/x86_64/repodata/d370878dcea587ad1a720619d162d84fc268b44e65721ff72fd872465d4f49de-updateinfo.xml.bz2: [Errno 14] HTTP Error 404 - Not Found

I wonder if we could find a way for CI tests not to have to rely on yum/dnf repos?

@rhatdan
Copy link
Member

rhatdan commented Aug 19, 2019

LGTM
@mheon @baude @vrothberg @TomSweeneyRedHat @ashley-cui @QiWang19 @jwhonce PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests.

@giuseppe
Copy link
Member Author

@cevich I think we need to update quay.io/libpod/in_podman:latest as it is still using the old version for the CNI plugins

@giuseppe
networking: use firewall plugin
99983e2 
drop the pkg/firewall module and start using the firewall CNI plugin.
It requires an updated package for CNI plugins.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@cevich
Copy link
Member

cevich commented Aug 19, 2019

still using the old version for the CNI plugins

That's in contrib/podmanimage, builds automatically after merge (making it complex to test in a PR) 😞

@giuseppe
Copy link
Member Author

@cevich I've moved the second patch to #3853

@giuseppe
Copy link
Member Author

That's in contrib/podmanimage, builds automatically after merge (making it complex to test in a PR) disappointed

where do we build it? Can I see the logs? I am afraid the image is not built correctly since the updated CNI plugins are already present on Fedora

@giuseppe
Copy link
Member Author

tests are finally passing! 🎉 🎉 🎉 🎉

@mheon PTAL

@mheon
Copy link
Member

mheon commented Aug 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@mheon
Copy link
Member

mheon commented Aug 21, 2019

(It's done. It's finally done. We don't have to maintain that code anymore. Immense thanks for @giuseppe for handling this).

@openshift-merge-robot openshift-merge-robot merged commit 1ff984d into containers:master Aug 21, 2019
This was referenced Aug 21, 2019
Merged
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@rhatdan rhatdan Awaiting requested review from rhatdan

@mheon mheon Awaiting requested review from mheon

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@giuseppe @openshift-ci-robot @mheon @rhatdan @rh-atomic-bot @vrothberg @edsantiago @TomSweeneyRedHat @cevich @openshift-merge-robot