Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.6] [CI:DOCS] Update RELEASE_NOTES.md with Makefile change #19242

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 14, 2023

package and package-install targets have been renamed to rpm and rpm-install respectively.

Ref: #19226

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2023

@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2023

I think there's a github issue I can link to it in release notes.

`package` and `package-install` targets have been renamed to `rpm` and
`rpm-install` respectively.

Ref: containers#19226

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the v4.6-release-notes-package-rpm branch from 9eac103 to 70e30a2 Compare July 14, 2023 14:03
@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2023

updated. PTAL.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Jul 14, 2023

Sure
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 43e89a7 into containers:v4.6 Jul 14, 2023
@lsm5 lsm5 deleted the v4.6-release-notes-package-rpm branch July 14, 2023 15:35
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants