Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.6] Makefile: package -> rpm #19226

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #19214

/assign lsm5

The Makefile `package` and `package-install` targets have been renamed to `rpm` and `rpm-install` respectively. `rpm-install` needs to be run as root.

package and package-install targets have been renamed
to rpm and rpm-install respectively for clarity.

`make rpm` will now build rpm using HEAD.

Resolves: containers#18817

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

/lgtm

@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

/approve

@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

/hold

@lsm5 lsm5 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@lsm5
Copy link
Member

lsm5 commented Jul 13, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit f32dd49 into containers:v4.6 Jul 13, 2023
lsm5 added a commit to lsm5/podman that referenced this pull request Jul 14, 2023
`package` and `package-install` targets have been renamed to `rpm` and
`rpm-install` respectively.

Ref: containers#19226

Signed-off-by: Lokesh Mandvekar <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants