-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote: fix podman-remote play kube --userns #19203
remote: fix podman-remote play kube --userns #19203
Conversation
podman-remote --userns=auto works in rootless remote. $ bin/podman unshare cat /proc/self/uid_map
0 1000 1
1 524288 65536
$ bin/podman-remote play kube test.yaml
Pod:
d397dc09e978c0ed2416b0be6f8b7f2b517ca90b1ebc0742fe4c57c9d7710d3a
Container:
ef19b78add7b2696efecd79f4aed6f00ad71ce29a83166cfd62ef106de6c387a
$ bin/podman-remote exec testPod-testCtr cat /proc/self/uid_map
0 1000 1
1 524288 65536
$ bin/podman-remote play kube --replace --userns=auto test.yaml
Pods stopped:
d397dc09e978c0ed2416b0be6f8b7f2b517ca90b1ebc0742fe4c57c9d7710d3a
Pods removed:
d397dc09e978c0ed2416b0be6f8b7f2b517ca90b1ebc0742fe4c57c9d7710d3a
Secrets removed:
Volumes removed:
Pod:
1602ef3a9ebedbbcc3707cb9f406b1e5d9cda56fc77fa3f0cddef5eb83f77cea
Container:
0a17f031fe309d65a6a0ef4fa554fde54976ae7aa8e1db955b7fbf15357b14bb
$ bin/podman-remote exec testPod-testCtr cat /proc/self/uid_map
0 1 1024 |
f21ee42
to
92a2aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you also have to add the parameter to our swagger docs, see pkg/api/server/register_kube.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the previous comment is addressed
92a2aa1
to
d7b1f76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Fix `podman play kube --userns` to work in remote environment. Related: containers#17392 Signed-off-by: Toshiki Sonoda <[email protected]>
d7b1f76
to
c6b5b9a
Compare
Sorry, I fixed the e2e test and re-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, sstosh, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
may I know which version of the podman contain this commit will be release? |
Looks like podman 4.7 in October. |
Fix
podman play kube --userns
to work in remote environment.Related: #17392
Does this PR introduce a user-facing change?