-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: adapt play kube test on remote rootless #17392
e2e: adapt play kube test on remote rootless #17392
Conversation
Use podmanTest.PodmanBinary because podman-remote unshare cannot be used. Signed-off-by: Toshiki Sonoda <[email protected]>
The CI/CI system currently doesn't run on remote rootless. However, it still fails even if applying this commit, Maybe related to #16795 podman play kube --replace --userns=auto
podman-remote play kube --replace --userns=auto
test.yamlapiVersion: v1
kind: Pod
metadata:
creationTimestamp: "2019-07-17T14:44:08Z"
name: testPod
labels:
app: testPod
spec:
restartPolicy: Never
hostNetwork: false
containers:
- command:
- top
args:
- -d
- 1.5
env:
- name: HOSTNAME
image: quay.io/libpod/alpine:latest
name: testCtr
imagePullPolicy:
securityContext:
allowPrivilegeEscalation: true
privileged: false
readOnlyRootFilesystem: false
ports:
- containerPort:
protocol: TCP
workingDir: /
volumeMounts:
status: {} |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry for tardy review; it took me a while to convince myself that this test is meaningful under remote.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
In the remote environment, podman play kube --userns should work. Related: containers#17392 Signed-off-by: Toshiki Sonoda <[email protected]>
Fix `podman play kube --userns` to work in remote environment. Related: containers#17392 Signed-off-by: Toshiki Sonoda <[email protected]>
Use
podmanTest.PodmanBinary
because podman-remote unsharecannot be used.
Signed-off-by: Toshiki Sonoda [email protected]
Does this PR introduce a user-facing change?