Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile to force a shell when running command #18837

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

andyedwardsibm
Copy link
Contributor

@andyedwardsibm andyedwardsibm commented Jun 9, 2023

Address a build break on Ubuntu 20.04 in the Makefile whereby calling command fails

Fixes #18836

Does this PR introduce a user-facing change?

None

Signed-off-by: Andy Edwards [email protected]

Address a build break on Ubuntu 20.04 in the Makefile whereby calling `command` fails

Signed-off-by: Andy Edwards <[email protected]>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@dfr PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM
as @Luap99 noted, it would be good to get a head nod from @dfr as he's been making similar changes

@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2023

/approve
/lgtm
Thanks @andyedwardsibm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyedwardsibm, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6856c77 into containers:main Jun 10, 2023
@dfr
Copy link
Contributor

dfr commented Jun 12, 2023

Sorry for the late reply - I was away for the weekend. The change looks good to me.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on Ubuntu 20.04 platforms with "make: command: Command not found"
7 participants