Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Ubuntu 20.04 platforms with "make: command: Command not found" #18836

Closed
andyedwardsibm opened this issue Jun 9, 2023 · 1 comment · Fixed by #18837
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@andyedwardsibm
Copy link
Contributor

Issue Description

Since 7832879 went in yesterday, building Podman is failing on Ubuntu bionic (20.04) platforms with the following error:

~/podman/conmon/podman$ make
make: command: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
Makefile:170: *** Required variable NATIVE_GOOS value is undefined, whitespace, or empty.  Stop.

If I locally revert the change to the Makefile, or if I replace line 24 in the Makefile with SHELL := $(shell command -v bash;) then the make completes fine.

Steps to reproduce the issue

Steps to reproduce the issue

$# docker run --rm -it ubuntu:bionic

root@3d2afcc7bd1a:/# apt update && apt install -y make golang git
...
root@3d2afcc7bd1a:/# git clone https://github.com/containers/podman/
Cloning into 'podman'...
remote: Enumerating objects: 200207, done.
remote: Counting objects: 100% (1639/1639), done.
remote: Compressing objects: 100% (956/956), done.
remote: Total 200207 (delta 722), reused 1383 (delta 624), pack-reused 198568
Receiving objects: 100% (200207/200207), 139.04 MiB | 6.11 MiB/s, done.
Resolving deltas: 100% (143689/143689), done.
Checking out files: 100% (8193/8193), done.
root@3d2afcc7bd1a:/# cd podman
root@3d2afcc7bd1a:/podman# make
make: command: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
make: -c: Command not found
Makefile:169: *** Required variable NATIVE_GOOS value is undefined, whitespace, or empty.  Stop.

Describe the results you received

make: command: Command not found

Describe the results you expected

a completed build

podman info output

(can't build podman)

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

No response

Additional information

This looks similar to a problem that was fixed in containers/skopeo#1733 whereby command being a shell builtin somehow breaks the ability of make to find it. It's not a problem in Ubuntu 22.04, or on Red Hat. It can be fixed by adding a ; after the call. I'll make a PR for consideration

@andyedwardsibm andyedwardsibm added the kind/bug Categorizes issue or PR as related to a bug. label Jun 9, 2023
@andyedwardsibm andyedwardsibm changed the title Build fails on Ubuntu platforms with "make: command: Command not found" Build fails on Ubuntu 20.04 platforms with "make: command: Command not found" Jun 9, 2023
@andyedwardsibm
Copy link
Contributor Author

#18837 created

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant