Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Add support for podman-next magic #18545

Merged
merged 2 commits into from
May 18, 2023
Merged

Cirrus: Add support for podman-next magic #18545

merged 2 commits into from
May 18, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented May 11, 2023 •
edited
Loading

Rather than supporting a special-mode just for netavark/aardvark
testing [in podman CI], support testing with all the latest
podman-next COPR packages with a [CI:NEXT] magic string in DRAFT PRs.

The idea here is very similar to the netavark/aardvark special mode it
replaces. Most podman-dependencies do not have the level of
comprehensive CI as exist here. This new CI-mode allows testing
upstream updates to podman-dependencies without needing to roll out
a whole new package/release for them.

Also update documentation for this new mode.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 11, 2023
@cevich cevich mentioned this pull request May 11, 2023
Closed
@cevich
Copy link
Member Author

cevich commented May 15, 2023

With [CI:NEXT] in the description, there are a bunch of checkpoint & SELinux related system test failures. I didn't dig into them at all, since presumably these are actual issues caused by updating to the latest podman-next COPR packages (i.e. before any strong integration & testing has happened).

@cevich cevich changed the title [WIP] Cirrus: Add support for [CI:NEXT] magic [WIP] Cirrus: Add support for podman-next magic May 15, 2023
@cevich
Copy link
Member Author

cevich commented May 15, 2023

force-push: rebased

@lsm5
Copy link
Member

lsm5 commented May 16, 2023

With [CI:NEXT] in the description, there are a bunch of checkpoint & SELinux related system test failures. I didn't dig into them at all, since presumably these are actual issues caused by updating to the latest podman-next COPR packages (i.e. before any strong integration & testing has happened).

err, not caused by podman-next, but would need podman-next to verify if the latest changes work on the latest changes in other repos.

@cevich
Copy link
Member Author

cevich commented May 16, 2023

verify if the latest changes work on the latest changes in other repos.

Right, hmmmm. Some of this use-case is already covered. For example this PR opened by renovate. But renovate isn't set to propose for everything. So I can see this feature being useful to test packaging-level changes (i.e. items outside of strict code-dependencies).

@cevich
Copy link
Member Author

cevich commented May 16, 2023

@rhatdan PTAL (just to confirm), would this feature help you work on #18439 ?

@cevich cevich marked this pull request as ready for review May 16, 2023 16:10
@cevich cevich changed the title [WIP] Cirrus: Add support for podman-next magic Cirrus: Add support for podman-next magic May 16, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@cevich cevich requested a review from flouthoc May 16, 2023 16:13
@cevich
Copy link
Member Author

cevich commented May 16, 2023

@flouthoc This affects a CI-feature you originally requested. PTAL to confirm this will also work for your netavark/aardvark testing needs.

cevich added 2 commits May 16, 2023 12:17
@cevich
Cirrus: Remove support for [CI:COPR] magic
eb4f0bc 
This magic string isn't often used and may cause confusion with future
magic-string additions.  Remove it.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Cirrus: Add support for [CI:NEXT]
d1dcb08 
Rather than supporting a special-mode *just* for netavark/aardvark
testing [in podman CI], support testing with all the latest
`podman-next` COPR packages.

The idea here is very similar to the netavark/aardvark special mode it
replaces.  Most podman-dependencies do not have the level of
comprehensive CI as exist here.  This new CI-mode allows testing
upstream updates to podman-dependencies without needing to roll out
a whole new package/release for them.

Also update documentation for this new mode.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented May 16, 2023

force-push: Rebased and fixed conflicts.

@rhatdan
Copy link
Member

rhatdan commented May 16, 2023

LGTM

TomSweeneyRedHat
TomSweeneyRedHat reviewed May 17, 2023
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented May 18, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit abea786 into containers:main May 18, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@flouthoc flouthoc Awaiting requested review from flouthoc

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cevich @lsm5 @rhatdan @TomSweeneyRedHat @openshift-merge-robot