fix(deps): update common, image, and storage deps #18510

renovate · 2023-05-09T03:05:51Z

This PR contains the following updates:

Package	Type	Update	Change
github.com/containers/common	require	digest	`586a3be` -> `6eebb37`
github.com/containers/image/v5	require	digest	`07ced61` -> `dc6d2c8`
github.com/containers/storage	require	digest	`cc0d208` -> `73f2995`

Configuration

📅 Schedule: Branch creation - "before 11am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

vrothberg

Bloat LGTM, it's just a lot of new code.

@giuseppe @Luap99 PTAL

I restarted the flaked jobs.

giuseppe

LGTM

rhatdan · 2023-05-09T12:42:55Z

/approve
/lgtm
/hold

openshift-ci · 2023-05-09T12:43:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, renovate[bot], rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrothberg

Restarted flaked job

vrothberg · 2023-05-10T12:09:54Z

go.mod

 	github.com/containers/conmon v2.0.20+incompatible
 	github.com/containers/image/v5 v5.25.1-0.20230505072505-dc4a4be9cc1e
 	github.com/containers/libhvee v0.0.5
 	github.com/containers/ocicrypt v1.1.7
 	github.com/containers/psgo v1.8.0
-	github.com/containers/storage v1.46.1
+	github.com/containers/storage v1.46.2-0.20230508110141-51c23d59f8f3


The Debian job keeps failing. @nalind could something in storage have caused the jobs to fail? Curious that it only happens on Debian.

It doesn't appear to be interacting well with the version of buildah in the VM (1.28.2), though I can't trigger the same error when I run relevant specific integration test scripts in a manually-started VM.

@nalind Do we have to update the buildah version in the debian VM ?

Do we know which version that is?

No I am not sure about it, @cevich Could help us in confirming the version of buildah in debian VM

You can always use hack/get_ci_vm.sh to check and reproduce if needed.

That is, in fact, how I manually started the VM in which I wasn't able to reproduce the issue.

Ok this is very weird then.

It's 1.28.2+ds1-1+b3 in the c20230426t140447z-f38f37d12 image. I've got a fresh set of images building as I write this in case it helps.

Just checked the new image as it was building. It has a slightly newer 1.28.2+ds1-3.

flouthoc · 2023-05-17T07:08:24Z

Restarted test.

Apparently this matters, see containers#18510 (comment) Signed-off-by: Chris Evich <[email protected]>

openshift-ci · 2023-06-06T14:39:54Z

New changes are detected. LGTM label has been removed.

cevich · 2023-06-16T19:36:14Z

PR needs rebase.

okay, I checked the "renovate please rebase this" button.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Luap99 · 2023-06-23T15:05:10Z

Tests are breaking here!

I did a brief skim and apart from flakes one common factor seems to be a missing Storing signatures in push output.
Did containers/image#2001 remove this output, @mtrmac? Do we have to fixup all tests?

mtrmac · 2023-06-23T17:27:32Z

Yes, c/image is now not saying Storing signatures if there are no signatures to store.

It’s a purely aesthetic thing, so if this were a deadline blocker or something, I’m fine with temporarily reverting that.

OTOH I do think it’s a move in the right direction overall, so past the immediate short-term concerns I’d prefer the tests to be updated if they expect that output.

Do you need me to help with the test update?

Luap99 · 2023-06-26T13:23:28Z

If fixing the test is the right thing then I can do it, I just wanted an ack from you.

rhatdan · 2023-06-26T20:56:46Z

I believe the tests should be fixed.

openshift-merge-robot · 2023-06-29T00:12:19Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

renovate bot added dependencies Pull requests that update a dependency file release-note-none labels May 9, 2023

vrothberg added the bloat_approved Approve a PR in which binary file size grows by over 50k label May 9, 2023

vrothberg reviewed May 9, 2023

View reviewed changes

giuseppe approved these changes May 9, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023

openshift-ci bot assigned rhatdan May 9, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023

vrothberg reviewed May 10, 2023

View reviewed changes

Luap99 mentioned this pull request May 10, 2023

podman: add support for splitting imagestore using --imagestore #18224

Merged

flouthoc mentioned this pull request May 10, 2023

vendor: bump c/storage to v1.46.2-0.20230508110141-51c23d59f8f3 #18534

Closed

cevich mentioned this pull request May 16, 2023

Cirrus: Add support for podman-next magic #18545

Merged

cevich added a commit to cevich/podman that referenced this pull request May 17, 2023

Cirrus: Record the buildah version for reference

99cedae

Apparently this matters, see containers#18510 (comment) Signed-off-by: Chris Evich <[email protected]>

cevich mentioned this pull request May 17, 2023

Cirrus: Record the buildah version for reference #18608

Merged

This was referenced May 25, 2023

Static Routes #18369

Closed

[CI:DOCS] network-create: document new bclim option #18684

Merged

flouthoc mentioned this pull request May 28, 2023

DO NOT MERGE: buildah vendor treadmill #13808

Draft

Luap99 mentioned this pull request Jun 6, 2023

Add netavark and aardvark-dns to podman info #18803

Closed

renovate bot changed the title ~~fix(deps): update github.com/containers/common digest to 8d47831~~ fix(deps): update common, image, and storage deps Jun 6, 2023

renovate bot force-pushed the renovate/common-image-and-storage-deps branch from 0af4285 to 25b7d75 Compare June 6, 2023 14:39

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023

flouthoc mentioned this pull request Jun 8, 2023

cirrus,ci: default to overlay if using vfs #18822

Merged

renovate bot changed the title ~~Update common, image, and storage deps~~ fix(deps): update common, image, and storage deps Jun 13, 2023

renovate bot force-pushed the renovate/common-image-and-storage-deps branch from 59bf47d to c4d488c Compare June 13, 2023 11:34

Luap99 removed the bloat_approved Approve a PR in which binary file size grows by over 50k label Jun 13, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023

renovate bot force-pushed the renovate/common-image-and-storage-deps branch from c4d488c to 0fbd593 Compare June 16, 2023 19:38

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023

renovate bot force-pushed the renovate/common-image-and-storage-deps branch from 0fbd593 to 5c8ac9d Compare June 21, 2023 12:50

fix(deps): update common, image, and storage deps

b32a5cc

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot force-pushed the renovate/common-image-and-storage-deps branch from 5c8ac9d to b32a5cc Compare June 23, 2023 09:20

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023

renovate bot changed the title ~~fix(deps): update common, image, and storage deps~~ fix(deps): update common, image, and storage deps - autoclosed Jun 29, 2023

renovate bot closed this Jun 29, 2023

renovate bot deleted the renovate/common-image-and-storage-deps branch June 29, 2023 07:22

renovate bot changed the title ~~fix(deps): update common, image, and storage deps - autoclosed~~ fix(deps): update common, image, and storage deps Jun 29, 2023

renovate bot reopened this Jun 29, 2023

renovate bot restored the renovate/common-image-and-storage-deps branch June 29, 2023 21:04

rhatdan closed this Jun 30, 2023

renovate bot deleted the renovate/common-image-and-storage-deps branch July 1, 2023 10:39

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 29, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update common, image, and storage deps #18510

fix(deps): update common, image, and storage deps #18510

renovate bot commented May 9, 2023 •

edited

Loading

vrothberg left a comment

giuseppe left a comment

rhatdan commented May 9, 2023

openshift-ci bot commented May 9, 2023

vrothberg left a comment

vrothberg May 10, 2023

nalind May 10, 2023

flouthoc May 17, 2023

nalind May 17, 2023

flouthoc May 17, 2023

Luap99 May 17, 2023

nalind May 17, 2023

Luap99 May 17, 2023

cevich May 17, 2023

cevich May 17, 2023

flouthoc commented May 17, 2023

openshift-ci bot commented Jun 6, 2023

cevich commented Jun 16, 2023

Luap99 commented Jun 23, 2023

mtrmac commented Jun 23, 2023 •

edited

Loading

Luap99 commented Jun 26, 2023

rhatdan commented Jun 26, 2023

openshift-merge-robot commented Jun 29, 2023

fix(deps): update common, image, and storage deps #18510

fix(deps): update common, image, and storage deps #18510

Conversation

renovate bot commented May 9, 2023 • edited Loading

Configuration

vrothberg left a comment

Choose a reason for hiding this comment

giuseppe left a comment

Choose a reason for hiding this comment

rhatdan commented May 9, 2023

openshift-ci bot commented May 9, 2023

vrothberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flouthoc commented May 17, 2023

openshift-ci bot commented Jun 6, 2023

cevich commented Jun 16, 2023

Luap99 commented Jun 23, 2023

mtrmac commented Jun 23, 2023 • edited Loading

Luap99 commented Jun 26, 2023

rhatdan commented Jun 26, 2023

openshift-merge-robot commented Jun 29, 2023

renovate bot commented May 9, 2023 •

edited

Loading

mtrmac commented Jun 23, 2023 •

edited

Loading