Quadlet system tests - fix socket notification #18520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
May 9, 2023
Luap99
reviewed
May 9, 2023
test/system/252-quadlet.bats
Outdated
| @@ -467,7 +468,7 @@ EOF | |||
| [Container] | |||
| Image=$IMAGE | |||
| SecurityLabelDisable=true | |||
| Exec=sh -c "echo STARTED CONTAINER; echo "READY=1" | socat -u STDIN unix-sendto:\$NOTIFY_SOCKET; top" | |||
| Exec=sh -c "echo STARTED CONTAINER; echo "READY=1" | top" | |||
There was a problem hiding this comment.
this also should remove the echo "READY=1" | part
There was a problem hiding this comment.
Sorry, somehow I misread | as || and kept it
test/system/252-quadlet.bats
Outdated
| @@ -494,7 +495,7 @@ Image=$IMAGE | |||
| SecurityLabelType=spc_t | |||
| SecurityLabelLevel=s0:c100,c200 | |||
| SecurityLabelFileType=container_ro_file_t | |||
| Exec=sh -c "echo STARTED CONTAINER; echo "READY=1" | socat -u STDIN unix-sendto:\$NOTIFY_SOCKET; top" | |||
| Exec=sh -c "echo STARTED CONTAINER; echo "READY=1" | top" | |||
In some tests use Notify=yes while in others remove the notification Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
quadlet-test-notify
branch
from
aec02c3 to
8aaa13a
Compare
vrothberg
reviewed
May 9, 2023
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests use Notify=yes while in others remove the notification
Resolves: #18516
Does this PR introduce a user-facing change?
No