Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quadlet system tests use sdnotify=conmon but try to access notify socket in container #18516

Closed
Luap99 opened this issue May 9, 2023 · 0 comments · Fixed by #18520
Closed

quadlet system tests use sdnotify=conmon but try to access notify socket in container #18516

Luap99 opened this issue May 9, 2023 · 0 comments · Fixed by #18520
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@Luap99
Copy link
Member

Luap99 commented May 9, 2023

Most of the quadlet system tests seem to try to write to the NOTIFY_SOCKET but the units are generated with --sdnotify=conmon so the socket is not leaked.

To reproduce run the system tests and look in the journal afterwards

systemd-basic_R4EF6P20E4[101700]: 2023/05/09 14:45:55 socat[3] E sendto(5, 0x55bcd5a8f000, 8, 0, AF=1 "<anon>", 2): Invalid argument

So either we must drop echo "READY=1" | socat -u STDIN unix-sendto:\$NOTIFY_SOCKET from the commands or add Notify=yes to the quadlet units there.

@vrothberg @ygalblum @alexlarsson PTAL
@Luap99 Luap99 added the kind/bug Categorizes issue or PR as related to a bug. label May 9, 2023
@Luap99 Luap99 changed the title qudlet system tests use sdnotify=conmon but try to access notify socket in container quadlet system tests use sdnotify=conmon but try to access notify socket in container May 9, 2023
@ygalblum ygalblum mentioned this issue May 9, 2023
Merged
@Luap99 Luap99 added the quadlet label May 9, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quadlet system tests - fix socket notification ygalblum/podman
1 participant
@Luap99