libpod: Podman info output more network information

[sstosh]

podman info prints the network information about binary path,
package version, program version and DNS information.

Fixes: #18443

cni info

  networkBackendInfo:
    backend: cni
    dns:
      package: podman-plugins-4.5.0-1.fc38.x86_64
      path: /usr/libexec/cni/dnsname
      version: |-
        CNI dnsname plugin
        version: 1.3.1
        commit: unknown
    package: |-
      containernetworking-plugins-1.1.1-16.fc38.x86_64
      podman-plugins-4.5.0-1.fc38.x86_64
    path: /usr/libexec/cni

netavark info

  networkBackendInfo:
    backend: netavark
    dns:
      package: aardvark-dns-1.6.0-1.fc38.x86_64
      path: /usr/libexec/podman/aardvark-dns
      version: aardvark-dns 1.6.0
    package: netavark-1.6.0-2.fc38.x86_64
    path: /usr/libexec/podman/netavark
    version: netavark 1.6.0

Does this PR introduce a user-facing change?

Now podman info prints the network information about binary path, package version, program version and DNS information.

[Luap99]

Thanks for doing this, I really like the idea. However I think it would be much better to move the logic directly into the networkBackend in c/common and then add a function there called Info() to return the info you want. Alo I would rather have a proper struct with the info then a generic map.

You can move packageVersion and programVersion to some c/common util package if needed.

[Luap99]

This is a breaking change and thus cannot be made, I suggest adding a new NetworkBackendInfo field.

[flouthoc]

Just adding a note but totally upto @sstosh , once we have proper implementation in c/common as discussed above, I think PR could be easily extended to also include aardvark-dns details. Then this will close: #18443

[baude]

@sstosh what say you?

[sstosh]

Just adding a note but totally upto @sstosh , once we have proper implementation in c/common as discussed above, I think PR could be easily extended to also include aardvark-dns details. Then this will close: #18443

@flouthoc OK. I also will try to add the feature to show the details of aardvark-dns.

[sstosh]

The output is as shown below:

  networkBackend: netavark
  networkBackendInfo:
    aardvark-package: aardvark-dns-1.6.0-1.fc37.x86_64
    aardvark-path: /usr/libexec/podman/aardvark-dns
    aardvark-version: aardvark-dns 1.6.0
    netavark-package: netavark-1.6.0-2.fc37.x86_64
    netavark-path: /usr/libexec/podman/netavark
    netavark-version: netavark 1.6.0

  networkBackend: cni
  networkBackendInfo: null

[flouthoc]

@sstosh Thank you 😄 output LGTM

[Luap99]

@sstosh Can you rebase, the new c/common is merged into main.

[sstosh]

The review is ready.

[flouthoc]

LGTM Thanks @sstosh

[Luap99]

LGTM, thank you

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Luap99, sstosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

/lgtm