libnetwork: add NetworkInfo() for get network information #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstosh
force-pushed
the
networkinfo
branch
2 times, most recently
from
1c77e5f to
f241567
Compare
Luap99
requested changes
May 10, 2023
|
podman info prints the network information as shown below: networkBackendInfo:
backend: cni
dns:
package: podman-plugins-4.5.0-1.fc37.x86_64
path: /usr/libexec/cni/dnsname
package: |-
containernetworking-plugins-1.1.1-8.fc37.x86_64
podman-plugins-4.5.0-1.fc37.x86_64
path: /usr/libexec/cni networkBackendInfo:
backend: netavark
dns:
package: aardvark-dns-1.6.0-1.fc37.x86_64
path: /usr/libexec/podman/aardvark-dns
version: aardvark-dns 1.6.0
package: netavark-1.6.0-2.fc37.x86_64
path: /usr/libexec/podman/netavark
version: netavark 1.6.0 |
Luap99
reviewed
May 15, 2023
|
|
||
| dnsPath := filepath.Join(path, "dnsname") | ||
| dnsPackage := cutil.PackageVersion(dnsPath) | ||
| if _, err := os.Stat(dnsPath); err == nil { |
There was a problem hiding this comment.
At least for dnsname you can get the version from the binary as well:
$ /usr/libexec/cni/dnsname --version
CNI dnsname plugin
version: 1.3.1
commit: unknown
There was a problem hiding this comment.
Add a wrapper function ProgramVersionDnsname() to get the dnsname information.
AFAICS, dnsname --version returns the information to stdErr.
# /usr/libexec/cni/dnsname --version > /dev/null
CNI dnsname plugin
version: 1.3.1
commit: unknown
# /usr/libexec/cni/dnsname > /dev/null
CNI dnsname plugin
version: 1.3.1
commit: unknown
# /usr/libexec/cni/dnsname --version 2> /dev/null
# /usr/libexec/cni/dnsname 2> /dev/null
|
podman info prints the network information as shown below: networkBackendInfo:
backend: cni
dns:
package: podman-plugins-4.5.0-1.fc37.x86_64
path: /usr/libexec/cni/dnsname
version: |-
CNI dnsname plugin
version: 1.3.1
commit: unknown
package: |-
containernetworking-plugins-1.1.1-8.fc37.x86_64
podman-plugins-4.5.0-1.fc37.x86_64
path: /usr/libexec/cni networkBackendInfo:
backend: netavark
dns:
package: aardvark-dns-1.6.0-1.fc37.x86_64
path: /usr/libexec/podman/aardvark-dns
version: aardvark-dns 1.6.0
package: netavark-1.6.0-2.fc37.x86_64
path: /usr/libexec/podman/netavark
version: netavark 1.6.0 |
sstosh
force-pushed
the
networkinfo
branch
3 times, most recently
from
dd7d770 to
6595ffb
Compare
NetworkInfo() return the network binary path, package version, program version and DNS information. Signed-off-by: Toshiki Sonoda <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, rhatdan, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkInfo()return the network binary path,package version and program version.
Related to containers/podman#18383