Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more "podman-default-kube-network" flakes #18273

Closed

Conversation

edsantiago
Copy link
Member

...in "built using Dockerfile" test.

References: Issue #17946, PR #18085

Signed-off-by: Ed Santiago [email protected]

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2023
@edsantiago
Copy link
Member Author

Link to the CI failure

...in "built using Dockerfile" test and "play kube fail with
custom selinux label" test. The latter, since it's in a test
file with lots of other kube tests, I just put into BeforeEach().

References: Issue containers#17946, PR containers#18085

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago force-pushed the another_custom_network branch from a807814 to 4486891 Compare April 20, 2023 01:43
@edsantiago edsantiago changed the title Fix another "podman-default-kube-network" flake Fix more "podman-default-kube-network" flakes Apr 20, 2023
@edsantiago
Copy link
Member Author

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Luap99 PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is not the right way to fix it. It will cause a lot more flakes. I just looked at the first two logs and see this: https://api.cirrus-ci.com/v1/artifact/task/4592789598502912/html/int-podman-fedora-36-root-host-boltdb.log.html

Please see #17975 (comment) again. We cannot ever use a custom config when you run containers.

To be explicit:
As root you can only use a custom network dir when you never run a container with it. Having the same network dir is important to avoid conflict in subnets and interface names which will cause problems at runtime in one way or another. The only exception here is containers that use the default podman network, they can be used with a custom network dir because the default network as this is built from memory with always the same values.

@Luap99
Copy link
Member

Luap99 commented Apr 20, 2023

To fix these flakes you need to find the test actually deleting the configs. #18085 tried to do it, looks like there are more.

@edsantiago edsantiago closed this Apr 20, 2023
@edsantiago edsantiago deleted the another_custom_network branch April 20, 2023 11:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants