test/e2e: use fresh network config dir for each test #17975
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Note while this works it still needs some cleanup follow-up changes thus I marked it as draft. |
Luap99
force-pushed
the
e2e-networks-dir
branch
2 times, most recently
from
654077e to
d4a2e8e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
The e2e test are isolated and have their own --root/--runroot arguments. However networks were always shared, this causes problem with tests that do a prune or reset because they can effect other parallel running tests. Over the time I fixed some of of these cases to use their own config dir but containers#17946 suggests that this is not enough. Instead of trying to find and fix these tests just go with the big hammer and make every test use a new clean network config directory. This will also make the use of `defer podmanTest.removeNetwork(...)` unnecessary. This is required at the moment for every test which creates a network. However to keep the diff small and to see if it is even working I will do it later in a follow up commit. Fixes containers#17946 Signed-off-by: Paul Holzinger <[email protected]>
Now that we ran each test with their own custom config there is no need to have the special cases anymore. Signed-off-by: Paul Holzinger <[email protected]>
Now that each test has its own custom network config dir we now longer have to explicitly cleanup the network because it is just a file which will be deleted in the test cleanup anyway. Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
e2e-networks-dir
branch
from
d4a2e8e to
4f281ec
Compare
|
Ok this is not going to work, it will introduce much more flakes than it fixes. Thus I am closing this PR as it is incorrect, the correct fix is to manually check for all tests which do a prune or reset and make those are using a custom directory, see the change from the second commit here. |
github-actions
bot
added
the
locked - please file new issue/PR
The e2e test are isolated and have their own --root/--runroot arguments. However networks were always shared, this causes problem with tests that do a prune or reset because they can effect other parallel running tests.
Over the time I fixed some of of these cases to use their own config dir but #17946 suggests that this is not enough. Instead of trying to find and fix these tests just go with the big hammer and make every test use a new clean network config directory.
This will also make the use of
defer podmanTest.removeNetwork(...)unnecessary. This is required at the moment for every test which creates a network. However to keep the diff small and to see if it is even working I will do it later in a follow up commit.Fixes #17946
Does this PR introduce a user-facing change?