Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ginkgo v2 #18163

Merged
merged 23 commits into from
May 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4458150
update to ginkgo v2
Luap99 Apr 12, 2023
666e314
ginkgo v2: remove deprecated flags
Luap99 Apr 12, 2023
c564d9d
ginkgo v2: remove CurrentGinkgoTestDescription()
Luap99 Apr 12, 2023
fbb7c98
test/e2e: containers.conf tests add missing Wait()
Luap99 Apr 12, 2023
b9ba850
Lower e2e timeout to not waste time when it hangs
Luap99 Apr 12, 2023
629a6a6
test/e2e: actually check for cleanup errors
Luap99 Apr 12, 2023
9bd833b
test/e2e: fix "podman run ipcns ipcmk container test"
Luap99 Apr 12, 2023
9c1f713
test/e2e: fix Cleanup()
Luap99 Apr 13, 2023
8cc7a36
ginkgo: run on all cores
Luap99 Apr 13, 2023
cc19091
test/e2e: unset CONTAINERS_CONF before Cleanup()
Luap99 Apr 13, 2023
fb7a966
test/e2e: switch to GinkgoWriter
Luap99 Apr 13, 2023
2ce4e93
ginkgo v2: drop localbenchmarks
Luap99 Apr 13, 2023
cd46e72
test/e2e: fix pause tests to unpause before cleanup()
Luap99 Apr 13, 2023
bc1ed07
ginkgo v2: fix new Skip() behavior
Luap99 Apr 13, 2023
c5922cc
test/e2e: fix CleanupVolume/Secrets()
Luap99 Apr 14, 2023
054154c
test/e2e: run system reset test serial
Luap99 Apr 17, 2023
b3424f3
test/e2e: unshare --rootless-netns cleanup slirp4netns
Luap99 Apr 18, 2023
914ff01
WIP: logformatter: handle ginkgo v2 logs
edsantiago Apr 13, 2023
1bff010
logformatter: anchors: link to test summary, not name
edsantiago Apr 18, 2023
5eb99a0
test/e2e: fix custom timing reporting
Luap99 Apr 21, 2023
c4b9f4b
ginkgo-v2 cleanup workaround for #18180
Luap99 Apr 28, 2023
5af4339
pkg/machine/e2e: switch to GinkgoWriter
Luap99 May 2, 2023
3858a83
Makefile: do not run machine test in parallel
Luap99 May 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions test/e2e/common_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package integration

import (
"bufio"
"bytes"
"errors"
"fmt"
Expand Down Expand Up @@ -167,11 +168,40 @@ func (p *PodmanTestIntegration) Setup() {
INTEGRATION_ROOT = filepath.Join(cwd, "../../")
}

var _ = SynchronizedAfterSuite(func() {},
var _ = SynchronizedAfterSuite(func() {
f, err := os.Create(fmt.Sprintf("%s/timings-%d", LockTmpDir, GinkgoParallelProcess()))
Expect(err).ToNot(HaveOccurred())
defer f.Close()
for _, result := range testResults {
_, err := f.WriteString(fmt.Sprintf("%s\t\t%f\n", result.name, result.length))
Expect(err).ToNot(HaveOccurred(), "write timings")
}
},
func() {
sort.Sort(testResultsSortedLength{testResults})
testTimings := make(testResultsSorted, 0, 2000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I hope this finally fixes #8358

for i := 1; i <= GinkgoT().ParallelTotal(); i++ {
f, err := os.Open(fmt.Sprintf("%s/timings-%d", LockTmpDir, i))
Expect(err).ToNot(HaveOccurred())
defer f.Close()
scanner := bufio.NewScanner(f)
for scanner.Scan() {
text := scanner.Text()
timing := strings.SplitN(text, "\t\t", 2)
if len(timing) != 2 {
Fail(fmt.Sprintf("incorrect timing line: %q", text))
}
name := timing[0]
duration, err := strconv.ParseFloat(timing[1], 64)
Expect(err).ToNot(HaveOccurred(), "failed to parse float from timings file")
testTimings = append(testTimings, testResult{name: name, length: duration})
}
if err := scanner.Err(); err != nil {
Expect(err).ToNot(HaveOccurred(), "read timings %d", i)
}
}
sort.Sort(testResultsSortedLength{testTimings})
GinkgoWriter.Println("integration timing results")
for _, result := range testResults {
for _, result := range testTimings {
GinkgoWriter.Printf("%s\t\t%f\n", result.name, result.length)
}

Expand Down