-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: integration timing results are randomly incomplete #8358
Comments
A friendly reminder that this issue had no activity for 30 days. |
@baude @edsantiago Still an issue? |
Yes but I seem to be the only one who cares |
I just hit performance variations in the remote system tests in #8747. @edsantiago and I looked into a VM together and noticed performance variations on Ubuntu 20.04. #8747 bumps the time out from 60 to 120 seconds. |
A friendly reminder that this issue had no activity for 30 days. |
@edsantiago @vrothberg Since we merged the bump can we close this issue? |
The issue is not fixed. Example: ubuntu 2010 log for PR 9082. Search in-page for "preserves container". The test is run, but there is no summary line. Compare to ubuntu 2004 log for same PR. Here the test is run and also summarized at bottom. This is a problem because we still don't understand why ubuntu 2010 runs slower than 2004, and without logged timing results there is no possible way to actually look into the difference. I really feel like this must be a trivial one-line fix for someone who understands Go arrays and threads. |
Use a mutex to synchronize the slice for storing tests results. Running the e2e tests in parallel is otherwise subject to race conditions surfacing in lost entries. Fixes: containers#8358 Signed-off-by: Valentin Rothberg <[email protected]>
Compare two CI logs, one ubuntu-19 and one 20. Search in-page for
test path
, orreimport
, orcheck dnsname
, or many many others (I'm just offering short easy-to-search-for strings). Note that those appear in the bottomtiming results
section only on one page, not the other, although the tests ran on both.Something is gobbling up timing results; this seems like a good place to start looking:
podman/test/e2e/common_test.go
Lines 346 to 349 in 9fa09a8
@baude weren't you looking into this some months ago?
The text was updated successfully, but these errors were encountered: