Fix invalid pod name and hostname during kube generate #18068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
umohnani8
commented
Apr 5, 2023
Luap99
reviewed
Apr 5, 2023
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Kube generate on pods was not checking for any underscores in the pod name so was creating a kube yaml with an invalid pod name when there were underscores present. The hostname for the pod is set to the podname by default. There is no need to set that to the container's name or the pod name again in the generated yaml. So removed that field unless a hostname was set for the container by the user. Signed-off-by: Urvashi Mohnani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kube generate on pods was not checking for any underscores in the pod name so was creating a kube yaml with an invalid pod name when there were underscores present.
The hostname for the pod is set to the podname by default. There is no need to set that to the container's name or the pod name again in the generated yaml. So removed that field as well.
Fixes #18054
Does this PR introduce a user-facing change?