Deploy to k8s generates an invalid pod name with underscore character.

[peterclauterbach]

Bug description

The "deploy to Kubernetes" generates an invalid pod name with an underscore in it i.e. (condescendingcurie_pod).
Removing the underscore from the generated name allows me to deploy the pod into my OpenShift cluster.
The expected behavious is that the generated pod and metadata would not require user intervention to deploy.
P.S. Substituting a dash instead of an underscore works fine.

Operating system

macOS Ventura 13.2.1

Version

0.13.0

Steps to reproduce

1. pull alpine image
2. run. container based on alpine image.
3. Deploy to Kubernetes

Relevant log output

Generated pod to deploy to Kubernetes:

apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: 2023-04-03T20:43:56.000Z
  labels:
    app: blissfulpikepod
  name: blissfulpike_pod
spec:
  containers:
  - image: [docker.io/library/alpine:latest](http://docker.io/library/alpine:latest)

Pod Name:
blissfulpike_pod
Use Kubernetes Services:
 Replace .hostPort exposure on containers by Services. It is the recommended way to expose ports, as a cluster policy may prevent to use hostPort.
Create OpenShift routes:
 Create OpenShift routes to get access to the exposed ports of this pod.
Kubernetes Context:
admin
Kubernetes namespace:

default
Error: Pod "blissfulpike_pod" is invalid: metadata.name: Invalid value: "blissfulpike_pod": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
 Docker Compatibility
 Compose
v0.13.0

Additional context

No response

[benoitf]

hello @peterclauterbach I'm transferring the issue to podman as podman is generating the pod YAML.

issue can be reproduced with a Kubernetes cluster

$ podman pod create my_pod
$ podman run -d -ti --pod my_pod fedora
$ podman kube generate my_pod > /tmp/pod.yaml

$ kubectl apply -f /tmp/foo.yaml                                                                                                                                                                              The Pod "my_pod" is invalid:
* metadata.name: Invalid value: "my_pod": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
* spec.hostname: Invalid value: "my_pod": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

[rhatdan]

@umohnani8 PTAL We need this in 4.5?