macos pkginstaller: fix regression which caused the installer to fail #17916
Conversation
Since commit bae07b6 we exit with 1 one errors. This caused problem for the mac installer which fails because of the error now. If the helper is already installed do not treat this as hard error and just log it instead. Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Make sure we can install podman even when the podman-mac-helper install command fails. This used to be the behavior but commit bae07b6 caused the regression because the binary now returns 1 as exit code on errors. [NO NEW TESTS NEEDED] I am not sure if we can test the install step in CI. Fixes containers#17910 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
mac-helper-error
branch
from
924b526 to
64ba826
Compare
|
@mheon @ashley-cui FYI, I think we should consider creating another 4.4.X release with this. My change broke the 4.4.3 mac installer unfortunately. |
|
SGTM. Should probably try and get it out quickly next week. |
|
Change LGTM |
|
/cherry-pick v4.4 |
|
@ashley-cui: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ashley-cui: new pull request created: #17919 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
podman-mac-helper: install: do not error if already installed
Since commit bae07b6 we exit with 1 one errors. This caused problem
for the mac installer which fails because of the error now.
If the helper is already installed do not treat this as hard error and
just log it instead.
macos pkginstaller: do not fail when podman-mac-helper fails
Make sure we can install podman even when the podman-mac-helper install
command fails. This used to be the behavior but commit bae07b6 caused
the regression because the binary now returns 1 as exit code on errors.
Fixes #17910
Does this PR introduce a user-facing change?