Skip to content

Commit

Permalink
macos pkginstaller: do not fail when podman-mac-helper fails
Browse files Browse the repository at this point in the history
Make sure we can install podman even when the podman-mac-helper install
command fails. This used to be the behavior but commit bae07b6 caused
the regression because the binary now returns 1 as exit code on errors.

[NO NEW TESTS NEEDED] I am not sure if we can test the install step in
CI.

Fixes #17910

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Mar 24, 2023
1 parent 4f3cbf1 commit 64ba826
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion contrib/pkginstaller/scripts/postinstall
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ echo "/opt/podman/bin" > /etc/paths.d/podman-pkg
ln -s /opt/podman/bin/podman-mac-helper /opt/podman/qemu/bin/podman-mac-helper
ln -s /opt/podman/bin/gvproxy /opt/podman/qemu/bin/gvproxy

/opt/podman/bin/podman-mac-helper install
# make sure to ignore errors, this is not a hard requirement to use podman
/opt/podman/bin/podman-mac-helper install || :

0 comments on commit 64ba826

Please sign in to comment.