4.4 backports #17891
Merged
4.4 backports #17891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
openshift-ci
bot
added
do-not-merge/hold
|
Looks like you need to update the capabilities tests as well. |
Pulls in fixes to add back the SYS_CHROOT to the default set of capabilities and to pull in fixes for the Docker-compat /auth endpoint which will be cherry-picked in a subsequent commit. Signed-off-by: Valentin Rothberg <[email protected]>
Use `auth.Login` as `podman login` does which parses and normalizes the input addresses correctly, especially for docker.io. [NO NEW TESTS NEEDED] as we do not have means to test logging into docker.io in CI. Fixes: containers#17571 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
4.4-backports
branch
from
d283360 to
d6ea398
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😰 right on time before the 4.4.3 release.
@mheon @baude @ashley-cui @lsm5 PTAL
Does this PR introduce a user-facing change?