-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker login compatibility issue #17571
Comments
Thanks for reaching out, @stratdev3! The issue seems unrelated to running inside a container but Docker talking to the Podman socket.
|
Add an option to not write back the credentials to the authfile or any credential helper. The `/auth` compat endpoint of Podman is currently not using this code here which ultimately led to normalization errors surfacing in containers/podman/issues/17571. The new option allows the endpoint to use this function without writing back the credentials. Signed-off-by: Valentin Rothberg <[email protected]>
Use `auth.Login` as `podman login` does which parses and normalizes the input addresses correctly, especially for docker.io. [NO NEW TESTS NEEDED] as we do not have means to test logging into docker.io in CI. Fixes: containers#17571 Signed-off-by: Valentin Rothberg <[email protected]>
I see this PR just been merged, thanks! 🚀 Is there any ETA for when this would be released? 🙂 |
@ashley-cui @mheon are there plans for another patch release? |
@cristianrgreco if you need it in RHEL, please open a ticket in the Red Hat Bugzilla. |
thanks for patch |
I was not thinking of another release before 4.5, but we can rethink if we
fix something important enough.
…On Mon, Mar 13, 2023 at 11:44 stratdev3 ***@***.***> wrote:
thanks for patch
—
Reply to this email directly, view it on GitHub
<#17571 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCGKQJCLYPW4H3THKE3W346HVANCNFSM6AAAAAAVBR2N3U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
A patch would be amazing (or a lightning fast release of 4.5 😄), I am trying to integrate podman into our GHA pipelines and am totally blocked as our tests login to private registries. I am currently using 4.4.2 from here: https://download.opensuse.org/repositories/devel:kubic:libcontainers:unstable/Debian_Testing |
Thanks, @cristianrgreco! @mheon this fix here sounds important. It's somehow surprising it didn't blow up before. It would require some backports in c/common. |
Could this issue also be the reason why |
Please open a new issue. Thank you! |
Add an option to not write back the credentials to the authfile or any credential helper. The `/auth` compat endpoint of Podman is currently not using this code here which ultimately led to normalization errors surfacing in containers/podman/issues/17571. The new option allows the endpoint to use this function without writing back the credentials. Signed-off-by: Valentin Rothberg <[email protected]>
Use `auth.Login` as `podman login` does which parses and normalizes the input addresses correctly, especially for docker.io. [NO NEW TESTS NEEDED] as we do not have means to test logging into docker.io in CI. Fixes: containers#17571 Signed-off-by: Valentin Rothberg <[email protected]>
Use `auth.Login` as `podman login` does which parses and normalizes the input addresses correctly, especially for docker.io. This Cherry Picks containers#17581 and brings in necessary changes to run_test.go from i containers@5f86fae Addreses: https://bugzilla.redhat.com/show_bug.cgi?id=2183601 and https://bugzilla.redhat.com/show_bug.cgi?id=2183602 for the RHEL 8.8 and 9.2 ZeroDay The original Fixed: containers#17571 Signed-off-by: Valentin Rothberg <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
Issue Description
There is a docker login registry compatiliby issue.
Steps to reproduce the issue
using the original docker command, everything works fine :
but it fails with podman :
Describe the results you received
unable to login to registry with podman
Describe the results you expected
The login to registry should succeed.
podman info output
Podman in a container
Yes
Privileged Or Rootless
Rootless
Upstream Latest Release
No
Additional environment details
Additional environment details
Test with Nixos 22.11 stable release
Additional information
No response
The text was updated successfully, but these errors were encountered: