Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Temporarily disable version-check #17621

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[CI:DOCS] Temporarily disable version-check #17621

merged 1 commit into from
Feb 23, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 23, 2023

The script is broken and the maintainer temporarily unavailable to help fix it. Disable it for now, w/ reference to possible fix.

Ref: #17620

Does this PR introduce a user-facing change?

None

@cevich
Temporarily disable version-check
1f6f81f 
The script is broken and the maintainer temporarily unavailable to help
fix it.  Disable it for now, w/ reference to possible fix.

Signed-off-by: Chris Evich <[email protected]>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 23, 2023
@cevich cevich mentioned this pull request Feb 23, 2023
Merged
@cevich cevich marked this pull request as ready for review February 23, 2023 19:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@cevich
Copy link
Member Author

cevich commented Feb 23, 2023

Note: Since @edsantiago is out on PTO I'm not comfortable with merging #17620 to fix this problem w/o his say-so. Let's just disable the check for now until he gets back and is able to give it a proper review.

@edsantiago
Copy link
Member

/lgtm
/hold

I'm totally fine with disabling or even removing this. It was intended as a way to help Windows people find recent package versions, but if it's not doing that job, nuke it.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 23, 2023
@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@edsantiago
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit c4cfba5 into containers:main Feb 23, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cevich @edsantiago @openshift-merge-robot