[CI:DOCS] Fix docs/version-check always requesting updates

[cevich]

DEPENDS ON: #17621

As suggested by @edsantiago, the complex script and direct-link in the
docs are adding little value while increasing the CI maintenance burden.
Simply retire the script and strip the direct (versioned) links from the
docs.

---

Fixes (in cirrus-cron CI), this message always appearing & job failing:

+ docs/version-check
LATEST=v4.4.1
version-check: docs/tutorials/mac_win_client.md: needs updating.
version-check: Please run this script in an interactive shell, and I'll fix it.
version-check: docs/tutorials/podman-for-windows.md: needs updating.
version-check: Please run this script in an interactive shell, and I'll fix it.

Does this PR introduce a user-facing change?

None

[cevich]

@edsantiago PTAL when you have time, this is not critical but it is causing the daily cirrus-cron job on main to "fail". I'll open another PR to disable the version-check for now until we're able to work out a fix (this PR or otherwise).

[cevich]

Force-push: Rebased on #17621 + added revert.

[cevich]

force-push: Fixed missing DCO

[cevich]

/hold waiting-for-ed

[edsantiago]

I'm going to defer this. It's impossible to review today, because there's a release in progress: tag without build.

version-check: FATAL: Windows EXE missing: https://github.com/containers/podman/releases/download/v4.4.2/podman-4.4.2-setup.exe

And grep -o is not an option I've ever used, so I'd like to get super-familiar with it before approving this. That won't happen today.

I'm totally fine with just removing this step. I don't know if it really adds any value.

[cevich]

I'm totally fine with just removing this step. I don't know if it really adds any value.

In fact, now that I've thought about it, this is likely the case. Not too long ago I updated the Makefile to rename the Windows installer file w/o a version number. So I think this script can just be removed, and the docs updated to point at the Downloads page (where the unversioned Windows binary link should be maintained).

[cevich]

Correction: These markdown pages are about the released Windows installer, not the CI artifact. Still, I think Ed's right, including the version number and a direct link adds little value and a whole lot of (script) complications. Let's just remove it and the generic "release page" link is very likely good enough.

[cevich]

Force-push: Remove the script and update docs pages accordingly.

[cevich]

Force-push: Rebased and squashed.

[TomSweeneyRedHat]

LGTM
and happy green test buttons

[rhatdan]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/hold cancel