e2e tests: stop using UBI images #17017
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I'm in the middle of fixing the failures. It got really complicated. I expect to re-push in the next hour, with bigger-than-expected changes. Number of images: grrrr, I don't know. It really bothers me, too. |
Red Hat registry is too unreliable. (As of this writing in January 2023, quay.io is not much better, but this is a new flake. Ubi has been flaking for a year or more). Instead of UBI, use the new systemd-image added to system tests in containers#16814. Since this reduces the number of cached images, a few unrelated tests (image count) need to be tweaked. And, sigh, Fedora systemd colorizes boot messages by default, causing a failure where we don't see an expected Reached Target message. I don't want to rely on ASCII formatting codes, so I've updated the build-systemd-image script so it disables systemd colors, and have built a new systemd-image:20230106. Made a few small usability improvements to the script as well. Closes: containers#16695 Signed-off-by: Ed Santiago <[email protected]>
| @@ -192,7 +192,7 @@ var _ = Describe("Podman Benchmark Suite", func() { | |||
| needsRegistry: true, | |||
| init: func() { | |||
| port, user, pass := getPortUserPass() | |||
| session := podmanTest.Podman([]string{"push", "--tls-verify=false", "--creds", user + ":" + pass, UBI_INIT, "localhost:" + port + "/repo/image:tag"}) | |||
There was a problem hiding this comment.
Be sure to go to the gear at top and select 'Hide whitespace' (if you use github gui. If you pull, use git diff -w).
| @@ -113,12 +113,12 @@ WantedBy=default.target | |||
| cgroupPath := podmanTest.Podman([]string{"inspect", "--format='{{.State.CgroupPath}}'", ctrName}) | |||
| cgroupPath.WaitWithDefaultTimeout() | |||
| Expect(cgroupPath).Should(Exit(0)) | |||
| Expect(result.OutputToString()).To(Not(ContainSubstring("init.scope"))) | |||
| Expect(cgroupPath.OutputToString()).To(Not(ContainSubstring("init.scope"))) | |||
There was a problem hiding this comment.
EXTRA ATTENTION HERE, PLEASE! I'm pretty sure this was an existing bug (using result), but please give extra scrutiny here in case there could be unintended consequences.
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Red Hat registry is too unreliable. (As of this writing
in January 2023, quay.io is not much better, but this is
a new flake. Ubi has been flaking for a year or more).
Instead of UBI, use the new systemd-image added to system tests
in #16814. Since this reduces the number of cached images,
a few unrelated tests (image count) need to be tweaked.
And, sigh, Fedora systemd colorizes boot messages by default,
causing a failure where we don't see an expected Reached Target
message. I don't want to rely on ASCII formatting codes, so
I've updated the build-systemd-image script so it disables
systemd colors, and have built a new systemd-image:20230106.
Made a few small usability improvements to the script as well.
Closes: #16695
Signed-off-by: Ed Santiago [email protected]