Build and use a newer systemd image #16814
Conversation
openshift-ci
bot
added
release-note-none
approved
|
Tagging with DO NOT MERGE because I'm leaving on PTO in an hour and this is a wee bit bigger change than I feel comfortable with dropping. But I'm submitting anyway because @vrothberg might want to use the image in his new something-something tests. |
|
Thanks @vrothberg! The term I was looking for is "barrier". I don't know if this image has the magic barrier code, but feel free to play with it at your leisure. |
Thank you. Yes, the new image will somehow magically send the BARRIERS as systemd-notify sends them by default now. If tests pass with the new image, we're good. |
edsantiago
force-pushed
the
build-systemd-testimage
branch
from
b155421 to
6953c99
Compare
...based on f37, not f31. And make it fedora-minimal so it's smaller. And clean up dnf so it's even smaller. And tag it with our proper YMD tag, and commit the script that builds it. This broke the system-df tests. In the process of resolving that, I found those tests a little lacking. So, improve their coverage a little bit. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
build-systemd-testimage
branch
from
6953c99 to
16b595c
Compare
edsantiago
changed the title
|
@vrothberg I think this is ready to go; PTAL when convenient. The generated image has not changed since my initial commit last month; all I've done is fix tests and rebase. The generated image should have the |
There was a problem hiding this comment.
LGTM, thanks ton, @edsantiago!
@containers/podman-maintainers PTAL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Red Hat registry is too unreliable. (As of this writing in January 2023, quay.io is not much better, but this is a new flake. Ubi has been flaking for a year or more). Instead of UBI, use the new systemd-image added to system tests in containers#16814. Since this reduces the number of cached images, a few unrelated tests (image count) need to be tweaked. And, sigh, Fedora systemd colorizes boot messages by default, causing a failure where we don't see an expected Reached Target message. I don't want to rely on ASCII formatting codes, so I've updated the build-systemd-image script so it disables systemd colors, and have built a new systemd-image:20230106. Made a few small usability improvements to the script as well. Closes: containers#16695 Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
...based on f37, not f31. And make it fedora-minimal so it's
smaller. And clean up dnf so it's even smaller. And tag it
with our proper YMD tag, and commit the script that builds it.
Signed-off-by: Ed Santiago [email protected]