System Test Quadlet - Volume dependency test did not test the dependency #16970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the Container unit correctly references the volume Start the Container service and not the Volume one Remove the volume Print the name of the service when status does not match Signed-off-by: Ygal Blum <[email protected]>
|
@alexlarsson PTAL. The original test started the Volume service instead of the Container service. I assumed this wasn't the intended behavior, so I fixed the test instead of adding a new one. |
|
Yeah, this looks right to me. Some CI hickup though. |
|
@containers/podman-maintainers please take a loop and restart the flaky test |
vrothberg
approved these changes
Jan 3, 2023
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This was referenced Jan 3, 2023
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the Container unit correctly references the volume Start the Container service and not the Volume one Remove the volume
Print the name of the service when status does not match
Signed-off-by: Ygal Blum [email protected]
Does this PR introduce a user-facing change?
No